make args into a dict and use as **kwargs so can be used as a library or cli. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…args to pass in **kwargs
added little byte_order to the int.from_bytes(random.randbytes(16), byteorder='little') on L43 of src/core/main.py and turned arg.parse args into a dict to pass into generator class as **kwargs
Jon-Becker
approved these changes
Jul 1, 2023
|
lgtm! |
|
Cool yea I like using in jupyter notebook so this enables using it there.. also in docs maybe should explain the order of composition for users? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also added byte_order
int.from_bytes(random.randbytes(16), byteorder='little')on L43 .... this explains why i chose little: click here this explains why i chose little